[#355] Ligretto: migrate ligretto frontend to fsd #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bondiano
force-pushed
the
feature/355-migrate-to-fsd
branch
5 times, most recently
from
f681334
to
8a68682
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 48.63% | 373/767 |
| 🔴 | Branches | 24.53% | 26/106 |
| 🔴 | Functions | 26.07% | 55/211 |
| 🔴 | Lines | 46.27% | 310/670 |
Test suite run success
12 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 51c7992
Stonek79
reviewed
Sep 13, 2023
apps/ligretto-frontend/src/features/playground/ui/Playground.tsx
Outdated
Show resolved
Hide resolved
apps/ligretto-frontend/src/features/playground/ui/Playground.tsx
Outdated
Show resolved
Hide resolved
apps/ligretto-frontend/src/widgets/game-info/ui/GameSettings/GameSettingsContainer.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Artem Zverev <[email protected]>
bondiano
force-pushed
the
feature/355-migrate-to-fsd
branch
from
8a68682
to
5e9045d
Compare
Themezv
reviewed
Sep 15, 2023
Themezv
reviewed
Sep 15, 2023
apps/ligretto-frontend/src/shared/ui/Avatar/getRandomAvatar.spec.ts
Outdated
Show resolved
Hide resolved
Themezv
reviewed
Sep 15, 2023
Themezv
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GamePageContainer.tsx(from the issue):Before was 539 score using measure-modules tool
After become 487.